Commit 8a9674a

derdilla <82763757+NobodyForNothing@users.noreply.github.com>
2023-11-14 15:40:49
improve code quality
Signed-off-by: derdilla <82763757+NobodyForNothing@users.noreply.github.com>
1 parent d698580
Changed files (4)
lib
test
ui
lib/components/dialoges/add_measurement.dart
@@ -68,6 +68,7 @@ class _AddMeasurementDialogeState extends State<AddMeasurementDialoge> {
   @override
   void dispose() {
     firstFocusNode.dispose();
+    sysController.dispose();
     super.dispose();
   }
 
@@ -237,15 +238,9 @@ class _AddMeasurementDialogeState extends State<AddMeasurementDialoge> {
             ColorSelectionListTile(
               title: Text(localizations.color),
               onMainColorChanged: (Color value) {
-                if (value == Colors.transparent) {
-                  setState(() {
-                    needlePin = null;
-                  });
-                } else {
-                  setState(() {
-                    needlePin = MeasurementNeedlePin(value);
-                  });
-                }
+                setState(() {
+                  needlePin = (value == Colors.transparent) ? null : MeasurementNeedlePin(value);
+                });
               },
               initialColor: needlePin?.color ?? Colors.transparent,
               shape: RoundedRectangleBorder(
lib/components/measurement_list/measurement_list_entry.dart
@@ -39,6 +39,7 @@ class MeasurementListRow extends StatelessWidget {
                       if (context.mounted) {
                         model.addAndExport(context, measurement);
                       } else {
+                        assert(false, 'context not mounted');
                         model.add(measurement);
                       }
                     },
lib/model/blood_pressure.dart
@@ -107,6 +107,8 @@ class BloodPressureModel extends ChangeNotifier {
     notifyListeners();
   }
 
+  /// Adds a measurement to the model and tries to export all measurements, if [ExportSettings.exportAfterEveryEntry] is
+  /// true.
   Future<void> addAndExport(BuildContext context, BloodPressureRecord record) async {
     await add(record);
 
@@ -211,7 +213,7 @@ class MeasurementNeedlePin {
   }
 }
 
-// source: https://pressbooks.library.torontomu.ca/vitalsign/chapter/blood-pressure-ranges/ (last access: 20.05.2023)
+// source: https://pressbooks.library.torontomu.ca/vitalsign/chapter/blood-pressure-ranges/ (last access: 14.11.2023)
 class BloodPressureWarnValues {
   BloodPressureWarnValues._create();
 
test/ui/components/settings/color_picker_list_tile_test.dart
@@ -82,6 +82,7 @@ Widget _materialApp(Widget child) {
   );
 }
 
+/// Finds the widget with a specific color inside a [ColorPicker], when put into a [CommonFinders.byElementPredicate].
 bool Function(Element e) findColored(Color color) {
   return (e) =>
     e.widget is Container &&